Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-32700) feat(NC): add New Caledonian phone number check in SetPhoneNumber #7266

Merged
merged 8 commits into from
Nov 28, 2024
Merged

(PC-32700) feat(NC): add New Caledonian phone number check in SetPhoneNumber #7266

merged 8 commits into from
Nov 28, 2024
+107 −83

Conversation

lbeneston-pass
Copy link
Contributor

@lbeneston-pass lbeneston-pass commented Nov 22, 2024 •
edited
Loading

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32700

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS Capture d’écran 2024-11-22 à 16 07 04 Capture d’écran 2024-11-22 à 16 06 56 Capture d’écran 2024-11-22 à 16 06 44 Capture d’écran 2024-11-22 à 16 06 22
Android
Phone - Chrome
Desktop - Chrome

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@mleduc-pass mleduc-pass force-pushed the PC-32700 branch 2 times, most recently from bec9ff2 to c6d7082 Compare November 27, 2024 14:45
cgerrard-pass
cgerrard-pass reviewed Nov 27, 2024
View reviewed changes
src/features/identityCheck/pages/phoneValidation/helpers/isPhoneNumberValid.ts Outdated
return false
}
export function isPhoneNumberValid(number: string, country: string) {
const phoneNumber = parsePhoneNumberFromString(number, country as CountryCode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le "as" on essaye d'eviter au maximun, si tu peux pas faire autrement, il faut que t'expliques pourquoi avec un commentaire

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 1.5%)

See analysis details on SonarQube Cloud

@lbeneston-pass lbeneston-pass merged commit d220ba3 into master Nov 28, 2024
52 of 53 checks passed
@lbeneston-pass lbeneston-pass deleted the PC-32700 branch November 28, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgerrard-pass cgerrard-pass cgerrard-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbeneston-pass @cgerrard-pass @mleduc-pass